Oh! I forgot the END statement. Looks like my sleepiness got to meKilmatead wrote:But considering that EndCleanup() is nothing more than a removal of the 7za.exe, it looks rather like the Wipe() is executed regardless of a successful integrity check or not. I haven't intentionally created a fail-state to check it yet (in case PB is sneakier than I thought), but it doesn't look right.
![lol :lol:](./images/smilies/lol.gif)
*sigh I did not even think about this lol. Got to add this now too heh.Kilmatead wrote:Also, just after that (when setup is complete), you conveniently re-launch the program to save the user the trouble of clicking the shortcut again, except you forgot to pass any initially given arguments. Ain't minutia fun?
You hit exactly what I was most worried about when I woke up this morning. If I don't use APX, the file size for xp2KeyCrypt is like 700 KB. Kind of big. On the other hand, if I keep them separate like I did before, the UPX version of 7za does not trip any sort of virus flags (virustotal.com) and my own executable only trip 4 for being a packer. But if I combined them... it might be troublesome. However the results from virustotal are kind of positive but not sure yet haha. The heuristic might make it different.Kilmatead wrote:I have no doubt that many anti-virus toys will just love the idea of your binary unpacking another binary just to execute it - usually that sort of thing is reserved for static resources or DLL's. There's nothing wrong with doing it, and it is "cleaner" - but there may be pitfalls.On that same theme, if you're still playing with UPX compression, you'll note that that's one of the main causes of AutoIt/AHK scripts being flagged as evil-doers...
EDIT: I'm doing it this way now. UPX the 7za.exe executable and leave my program alone.
https://www.virustotal.com/en/file/a1e1 ... 375985143/
https://www.virustotal.com/en/file/0e57 ... 375985253/
So yeah, I might not go for it then. Going to have think more about it. On the other hand, X2.DAT being a 7-zip file is even less apparent with this method. Unless they pay attention now lol. Of course in terms of security, that means nothing.
Anyway I updated the binaries but it does not need testing I think. It's pretty much just that END statement being added so it's rather minor. I work on the other stuff later today when I get hope again haha.
EDIT: Ok. Now when you finish the first time encryption, it should now send the command-line arguments as well.
EDIT2: Link removed. The new executable and source is now in the first post.
Hahaha I feel down on XYplorer's forum for XYKeyCrypt. No feedback whatsoeverKilmatead wrote:Regrettably x2's "scripting" is indeed a limited affair, forcing us to be more inventive than your average litter of kittens. Having an open and practical API is one of those things that never seemed to dawn on Nikos, and x2 suffers for it - but such is life. Considering that file managers are niche-products anyway, the actual percentage of users who would delve to such a level is virtually non-existent - so it's kind of a chicken-vs-egg argument. He did not exactly imagine 10 years ago when x2 was initially pushing kicking and screaming into this life that weirdo's like myself would be messing with its entrails.
xyplorer's quite impressive for a manager written in basic, but it can never seem to get away from the "shiny" impression of too many niche-requests being granted for the sake of customer relations, and not enough attention brought to the depth of the shell itself. The same applies to x2 in reverse - a little more thought put into fluffy GUI nonsense (because people like their fluffy) wouldn't hurt. But that's just my opinion - at the end of the day all file managers essentially do the same thing and the users are just quibbling about the paint-job. Besides, we're not here to play comparison games, enough of that goes on elsewhere. (Although I will point out that your own xyKeyCrypt seems to have suffered a lukewarm reception so far on that forum - no discussions of assembly, no humor, no suggestions... where's the fun? You'll need to work harder to wake them up, the grumpy bunch.)
![Sad :(](./images/smilies/icon_sad.gif)
![Twisted Evil :twisted:](./images/smilies/icon_twisted.gif)
Actually Don's rather hard about implementing features lol. We have to spend a lot of time and prove to him that the feature is productive and is easy to use with customers that are now power users. If we can't convince him, we don't get the feature lol. It took us years before he finally agreed that basic zip support is useful. But yeah, I think it's extremely amazing how stable and good the program is yet it's written in Visual Basic. He fully prove that it's the programmer is the one that can work the magic with any language. On the other hand, the compiler is still an issue and therefore haven't figure out a good way to implement multi-threading and x64 version so that will continue to be the wall. It's expected though, all file managers have their own issues. Directory Opus is really really good but portability is a pain. And... it's huge. Very huge. But it's good! But it's huge. xplorer2 and XYPlorer are the lightweight ones and are the fun ones to take with you everywhere you go. Got stuck on a deserted island? Don't worry, you have xplorer2 and XYplorer ready to help you... and XYplorer can make coffee in the morning too if you need that.