IconPackager and xplorer²

Lazlo Woodbine · Post by **Lazlo Woodbine** » 2005 Jun 13, 09:22

More recent builds of IconPackager have included iprepair.dll which allows shell icon customisation in programs other than just Explorer. This works just great in xplorer², and all my icons get skinned ...... apart from the default icon which uses the crappy Windows original (in Explorer this icon is skinned correctly).

I've contacted Brian Harper, the developer of IconPackager, and his reply was this:

"I presume you have been into Windows Explorer and
looked at the same folder and the default icon is displayed properly? This
appears to be a bug within xplorer2 where the correct registry entry isn’t
being read when no icon exists for that association. Unfortunately, our
shell icon repair feature wouldn’t be able to fix this."

Is this something you could take a look at and fix?

Post by **nikos** » 2005 Jun 13, 10:48

the professional version of x2 is the only one that shows "skinned" icons
please download the trial and tell me if it works to your satisfaction

Lazlo Woodbine · Post by **Lazlo Woodbine** » 2005 Jun 13, 14:43

the professional version of x2 is the only one that shows "skinned" icons

That's not really true; IconPackager is skinning most icons without a problem, it was only really the default icon that was not skinned, even application icons were being skinned (only IP does this).

I couldn't run the trial, because I've run it in the past, so I just bought the full version as I'd been meaning to for a while anyway! It works great and the default icon is now skinned!

Thanks for your quick reply.

Lazlo Woodbine · Post by **Lazlo Woodbine** » 2005 Jun 13, 15:02

Actually, on review, xplorer² pro is still *not* displaying the correct icon. It is displaying *a* icon, but not the correct icon. Confusingly, it is choosing to display the icon for MS-DOS application, instead of the default icon. This is apparently an xplorer² issue, because Explorer is displaying the icon assigned as the default icon correctly.

Could you take a look at this please?

(Should I repost this in the pro forum??)

Post by **nikos** » 2005 Jun 13, 19:18

have you tried running the pro version without iconpackager's hook dll?

btw what do you mean by "default" icon? i am talking about that associated to files without extension or those without a file association

Lazlo Woodbine · Post by **Lazlo Woodbine** » 2005 Jun 13, 20:39

nikos wrote:have you tried running the pro version without iconpackager's hook dll?

I've just done it, and it makes no difference; xplorer² still displays the MS-DOS application icon when it should display the default icon. It's clearly not IconPackager though, since the default icon is correctly displayed by Windows Explorer.

btw what do you mean by "default" icon? i am talking about that associated to files without extension or those without a file association

That's exactly the icon I mean.

Post by **nikos** » 2005 Jun 14, 09:33

if you create an alien file type e.g. F7 for a file called a.nothere, what icon would explorer and x2 show and how does it compare to the icon in this registry key:

HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\Shell Icons\0

Lazlo Woodbine · Post by **Lazlo Woodbine** » 2005 Jun 14, 11:01

nikos wrote:if you create an alien file type e.g. F7 for a file called a.nothere, what icon would explorer and x2 show and how does it compare to the icon in this registry key:

HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\Shell Icons\0

Explorer is showing the icon defined in that registry key correctly.

xplorer² shows a completely different icon, defined by this registry key:

HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\Shell Icons\2

Post by **nikos** » 2005 Jun 14, 11:41

this doesn't make any sense since i am explicitly opening the "0" registry key. You are using the latest 1302 right? which windows OS?

Lazlo Woodbine · Post by **Lazlo Woodbine** » 2005 Jun 14, 11:45

1302 and XP Pro SP2

Post by **nikos** » 2005 Jun 14, 12:26

Lazlo Woodbine · Post by **Lazlo Woodbine** » 2005 Jun 14, 13:20

I've cleared the icon cache, removed IconPackager (after resetting to Windows icons), rebooted, and *still* xplorer² displays the wrong icon (and Explorer doesn't).

I can only conclude that the problem *is* in xplorer².

Regmon from Sysinternals shows that the '0 key' is being read by xplorer², and it is immediately followed by a read of the '2 key'. Perhaps xplorer² isn't making the correct assignment of icons at that point?

Post by **nikos** » 2005 Jun 14, 14:01

you really know your tools there

it reads both 0 and 2 since it needs both, that's expected
the puzzle is why it returns the msdos icon for unidentified documents
what icon do you see for plain executables? (those that don't have icons in their resources)

Lazlo Woodbine · Post by **Lazlo Woodbine** » 2005 Jun 14, 14:20

nikos wrote:it reads both 0 and 2 since it needs both, that's expected

I understand that.

the puzzle is why it returns the msdos icon for unidentified documents
what icon do you see for plain executables? (those that don't have icons in their resources)

They display the correct icon, taken from:

HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\Shell Icons\2

I do have a couple of thoughts:

1. Is it possible that the order of execution of reading and assigning these icons has become muddled? ie is the first icon read, not assigned, then the second read, and then the first and second assigned - that way assigning the same icon to both

2. Is it possible that source code has been copied and pasted from one assignment to the other, but without making the necessary changes?

I'm not a coder, so the above suggestions might be way off base...

Post by **nikos** » 2005 Jun 14, 14:50

there is no problem with the code since i've just tried x2 on an XP/SP2 with icontweaker and all customized icons show fine, including those 0/2 you have problems with

so why it doesn't work for you? i'll have to digress...

ps try removing registry keys 0 & 2, then what happens?
(extract them first so you can restore them)